Skip to content

feat(storage): migrate storage samples and tests#4263

Open
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:storage-storage-migration
Open

feat(storage): migrate storage samples and tests#4263
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:storage-storage-migration

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented Mar 23, 2026 •
edited
Loading

Description

Fixes Internal: b/495411121

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Mar 23, 2026
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 23, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 23, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant migration by introducing a new, dedicated storage/ directory to house Cloud Storage samples and their associated system tests. This restructuring aims to improve the organization and modularity of the codebase, making it easier to develop, test, and maintain storage-related examples. It also includes a new sample demonstrating custom API endpoint configuration and a cleanup script for managing test resources.

Highlights

  • New storage/ directory structure: Established a dedicated directory for Cloud Storage samples and tests, centralizing related code and resources.
  • Dedicated package.json: Introduced a package.json file within the storage/ directory to manage dependencies and scripts specific to storage samples.
  • Cleanup script: Added a utility script (scripts/cleanup) designed to identify and remove test-related storage buckets, ensuring a clean testing environment.
  • Custom endpoint sample: Included a new sample (setClientEndpoint.js) demonstrating how to configure a custom API endpoint for the Google Cloud Storage client.
  • System tests: Implemented system tests (system-test/storage.test.js) to verify the functionality of the new custom API endpoint sample.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new sample files for Google Cloud Storage, including test.txt, test2.txt, testSub1.txt, and a .gitignore entry for downloaded.txt. It also adds a cleanup script to remove sample-created storage buckets and a new sample setClientEndpoint.js demonstrating how to configure a custom API endpoint for the Storage client, accompanied by a new system test storage.test.js. The package.json is updated with new dependencies and script configurations. A review comment highlights a potential issue in the cleanup script regarding redundant bucket.deleteFiles() calls and incorrect error handling, which could lead to incomplete cleanup of test resources.

@angelcaamal angelcaamal marked this pull request as ready for review March 23, 2026 15:57
@angelcaamal angelcaamal requested review from a team as code owners March 23, 2026 15:57
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Mar 23, 2026 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@angelcaamal